Skip to content

fix(query): make LabelCardinalityExec scan limit configurable via execPlanLeafSamples - #2208

Open
bhavanap1131-cmd wants to merge 1 commit into
filodb:developfrom
bhavanap1131-cmd:metadata_limits
Open

fix(query): make LabelCardinalityExec scan limit configurable via execPlanLeafSamples#2208
bhavanap1131-cmd wants to merge 1 commit into
filodb:developfrom
bhavanap1131-cmd:metadata_limits

Conversation

@bhavanap1131-cmd

@bhavanap1131-cmd bhavanap1131-cmd commented Apr 23, 2026

Copy link
Copy Markdown
Contributor
  • Replaced hardcoded 1,000,000 scan limit in LabelCardinalityExec with
    queryContext.plannerParams.enforcedLimits.execPlanLeafSamples, making
    the limit configurable per query via planner params.
  • Fixed args method which was logging execPlanSamples instead of
    execPlanLeafSamples, causing exec plan output to show the wrong enforced limit.

…f hardcoded 1M limit

Replace the hardcoded 1,000,000 limit in LabelCardinalityExec with
queryContext.plannerParams.enforcedLimits.execPlanLeafSamples so the
limit is configurable per query. Add test verifying the limit is respected.
@bhavanap1131-cmd bhavanap1131-cmd changed the title fix(query): Use execPlanLeafSamples in LabelCardinalityExec instead o… fix(query): make LabelCardinalityExec scan limit configurable via execPlanLeafSamples May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants