fix(queryplanner): fix metadata query routing to multiple partitions - #2130
Open
bhavanap1131-cmd wants to merge 7 commits into
Open
fix(queryplanner): fix metadata query routing to multiple partitions#2130bhavanap1131-cmd wants to merge 7 commits into
bhavanap1131-cmd wants to merge 7 commits into
Conversation
alextheimer
reviewed
Feb 4, 2026
amolnayak311
requested changes
Feb 10, 2026
amolnayak311
left a comment
amolnayak311
left a comment
Contributor
There was a problem hiding this comment.
Please follow the connections given in https://github.com/filodb/FiloDB/blob/develop/CONTRIBUTING.md and update the PR title, and provide the summary of the changes
alextheimer
reviewed
Feb 12, 2026
alextheimer
reviewed
Feb 15, 2026
alextheimer
reviewed
Feb 20, 2026
alextheimer
reviewed
Feb 27, 2026
alextheimer
reviewed
Mar 4, 2026
alextheimer
reviewed
Mar 24, 2026
Contributor
|
@bhavanap1131-cmd Please confirm all review comments are adequately addressed before requesting further reviews. |
alextheimer
reviewed
Mar 30, 2026
alextheimer
reviewed
Apr 2, 2026
alextheimer
reviewed
Apr 6, 2026
alextheimer
reviewed
Apr 13, 2026
alextheimer
left a comment
alextheimer
left a comment
Contributor
There was a problem hiding this comment.
Huge thanks for all the iteration @bhavanap1131-cmd
This PR can be merged after this one last comment is addressed.
alextheimer
approved these changes
Apr 13, 2026
bhavanap1131-cmd
changed the title
amolnayak311
changed the title
amolnayak311
approved these changes
Apr 14, 2026
- Add resolveMetadataPartitions with fallback to getMetadataPartitions when shard key filters are non-Equals or useLegacyMetadataRouting is set - Pass TaskWorkUnit to PartitionAssignment - Add tests for fallback routing in MultiPartitionPlannerSpec - Add useLegacyMetadataRouting config to QueryConfig/RoutingConfig Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bhavanap1131-cmd
force-pushed
the
multiple_partitions
branch
from
June 9, 2026 15:47
05cb723 to
d58ebc5
Compare
alextheimer
reviewed
Jul 26, 2026
alextheimer
left a comment
alextheimer
left a comment
Contributor
There was a problem hiding this comment.
It looks like some tests are still missing. What about should not throw for regex filters on shard keys in metadata queries? That is mentioned in a comment just prior to the force-push.
Couple other tests that look like they are missing (just a few I see in the PR comments):
- should use getPartitions directly when a shard-key filter is missing
- should fallback to getMetadataPartitions when one shard-key filter is regex
- should handle non-equals filters gracefully in getPartitions delegation
There might be others, too. I would recommend using git reflog to find the state of the repo immediately prior to this commit. You can open a separate PR with that state, and I'll take a look. If that looks good, we can hard-reset the state of the original PR to that branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Current behavior:
Metadata queries (LabelValues, SeriesKeysByFilters, LabelNames, etc.) in MultiPartitionPlanner were
unconditionally routed through getMetadataPartitions (legacy fallback path), regardless of whether the
shard-key filters were sufficient for direct partition routing. SeriesKeysByFilters plans were also not
handled correctly since their filters are stored directly on the plan node rather than on RawSeries
leaves.
New behavior:
Introduced resolveMetadataPartitions which routes directly via getPartitions when all shard-key filters
are present and Equals, falling back to getMetadataPartitions otherwise. SeriesKeysByFilters plans are
now handled explicitly. Test coverage added in MultiPartitionPlannerSpec for all routing conditions
across both plan types. Broken and misplaced tests removed from PlannerHierarchySpec.
Other information:
processMultiPartition = true -- the partition provider was never called. Behaviour is covered in
MultiPartitionPlannerSpec.