Allow user to overwrite settings - #13
Merged
Merged
Conversation
The previous variable `default_db_name` made no sense as there are no other variables overwriting this. And even if the user wishes to do so, he/she can do it via env variables or another `.toml` file
The user can overwrite everything by creating a `kb_settings.toml` file instead of just creating environment variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles #6
Description
It is now possible to overwrite the existing settings with either:
KB_, such asKB_DB_NAME; orkb_settings.tomlfile with only the variables you want to overwrite. In this case, theKB_prefix and usage of uppercase is not required.Keep in mind that it is extremely advisable to not update these parameters for existing files.
The verification that there are inconsistencies is too cumbersome, and I decided to give freedom (and responsibility) to the user.