Repository navigation
Fix error page after successful WorkOS sign-in - #149
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AuthKit saves the WorkOS session before invoking
onSuccess. Clockwork's callback then performed a commerce membership lookup whose result was discarded. If that lookup failed, AuthKit returned HTTP 500 with “Couldn't sign in” while leaving the user signed in. This matches the reported sequence of an error after entering an email code followed by a working session when navigating directly to the app.Remove the duplicate lookup from the callback so successful authentication completes its redirect. The destination and protected operations still resolve commerce membership and permissions through
getCommerceSession; missing membership and database failures continue to deny commerce access. No roles, memberships, MFA policy, or provider error handling change.The release audit also exposed existing high-severity dependency advisories. Update Zod to 4.6.6 (advisory), body-parser to 2.4.0 (advisory), and undici to 8.12.2 (advisory). Trigger SDK/core moves to 4.6.4 to support Zod 4 without forcing an incompatible major version into its old consumer; preserve the scoped OpenTelemetry alignment. No new advisory exceptions are added.
Validation:
Production logs were not available in this environment, so the precise lookup exception for the reported attempt is unconfirmed. The earlier email delivery delay is separate and is not addressed by this callback change.