Repository navigation
Give PDF layout verification the existing render-test budget - #146
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The semantic quote-layout test inherited Vitest’s five-second default and timed out at 5.06 seconds during the parallel main release run, after passing the preceding PR runs. Give this single React PDF + Poppler test an explicit 30-second budget, matching the existing single-document PDF integration tests. All geometry assertions and the no-retry policy remain intact; this test verifies layout rather than latency.
Validation: all 56 document integration tests passed locally in 7.31 seconds; hooks passed. All nine CI shards and the aggregate release gate passed; the layout test completed in 2.1 seconds in CI and all 56 PDF integration tests passed.