Repository navigation
Add signing progress, in-flight voiding, and precise provider errors - #142
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
In-flight MNDAs and contracts can now be voided after the counterparty signs, with a required reason and confirmation that the provider copy and partial signatures will be deleted. The shared workflow refreshes and validates the exact provider binding, refuses completed or fully signed copies and signed mismatches, and preserves audit history and retry recovery.
A compact View progress disclosure shows confirmed preparation, approval where needed, sending, signatures, and final PDF storage. Rejected approvals and missing historical evidence no longer look like active progress; single-signer requests omit the counterparty step.
SignWell failures distinguish timeout, access, rate limits, and refused requests. Logs retain only the operation phase, bounded category, and HTTP status. The old generic error did not retain enough information to diagnose the reported production failure, so this change does not claim a cause or a guaranteed duplicate-free outcome.
Validation
Provider limitation
SignWell offers no documented conditional delete. A signer could complete between the fresh provider read and delete; this pre-existing remote race remains documented. No live documents were sent, signed, or canceled during verification. No external SignWell cancellation qualification was performed in this session. This PR does not include the separate PDF-spacing change in draft #141.