Repository navigation
Fix staff provisioning audit collisions - #139
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staff provisioning could not promote an existing production user: the role update succeeded inside its transaction, then its audit insert reused organization version 1 and failed the unique audit-version constraint, rolling the whole change back.
Record provisioning events on the affected membership stream, matching Team. Role changes use the membership ID and persisted version returned by the update; create and restore use the new membership at version 1. Preserve historical organization events and keep audit/outbox writes atomic with the role change.
Three real-database regressions exercise the actual provisioning function with existing organization and membership audit history. The original implementation fails all three with the production constraint error; the fix passes create, restore, successive role changes and an idempotent retry. Provider calls are mocked and off-host calls are trapped.
Validation: scoped integration tests, root/database typechecks, lint, formatting, dependency boundaries and normal hooks; bundled CLI execution and import behavior verified. Independent adversarial review passed. No permission guards or provider binding checks were relaxed.