Repository navigation
Close MCP workflow, pagination and reliability gaps - #137
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MCP completeness audit found three workflow gaps: capped lists could not reach older records, MNDA tools accepted signer/draft fields they did not expose for review, and contracts had no provider-status refresh. Add cursor pagination for pricing scenarios, handoffs and partners; expose active MNDA countersigners and draft details; and add
check_contract_statuswith an explicit signing-request number.MCP authentication backend outages now return a sanitized pre-execution 503 with Retry-After. Invalid credentials and rate limits retain their existing responses. Contract refresh uses the same authorization and stale-request protections as the app and only reads provider status/files; sending and approvals remain in the app.
Validation: 19 transport tests; 31 workflow/catalog tests; 2 real-route outbound-message guard tests; 8 MCP pagination tests; 11 cursor tests; 3 beyond-cap database cases (including ties and sub-millisecond ordering); 21 existing repository integration tests; web/database typechecks, lint, formatting and advisory checks. Independent adversarial reviews cleared transport, workflow and pagination changes. A one-off fake-network SDK-client lifecycle succeeded; durable tests retain the repository's SDK client-import advisory guard.
Also isolates the disposable staff test account from order-acceptance fallback ownership. A rollback-only reproduction confirmed the original cleanup foreign-key failure and verified that the fixture repair preserves unrelated exception cases. The two outbound-message guard tests and independent review pass.