Show running G-code source line during job playback#17
Draft
sfmissionmark wants to merge 2 commits into
Draft
Conversation
Track source line numbers in the parser and display the current line in the viewer progress strip while a job is running or held. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
This is actually not smoothly reporting the correct line number I think its jumping in buffer lengths or something. Taking this request back for testing. |
Store source text in the G-code store, add a Code toggle with a scrollable text panel and live line highlight, parse FluidNC Ln from status reports, and resolve the current line from toolpath progress instead of SD byte read. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Line X / Yin the viewer progress strip while a job is running or held|Ln:N|from status reports whenuse_line_numbersis enabled and map N-words to source linesTest plan
Line X / Yappears above the progress bar during Run/Holduse_line_numbers: truein FluidNC and N-words in G-code forLn:reporting