Skip to content

feat(apps): OME-Zarr/DICOM registration, IMPACTReg PCA, and app tests + examples - #37

Merged
vboussot merged 3 commits into
mainfrom
feat/impactreg-omezarr-impact
Jul 14, 2026
Merged

feat(apps): OME-Zarr/DICOM registration, IMPACTReg PCA, and app tests + examples#37
vboussot merged 3 commits into
mainfrom
feat/impactreg-omezarr-impact

Conversation

@vboussot

@vboussot vboussot commented Jul 13, 2026

Copy link
Copy Markdown
Member

OME-Zarr/DICOM store handling, the IMPACT-Reg registration app, and its examples.

Stacked on #36 (konfai-mcp) → #38 (model catalog). Review those first; this is the registration layer on top.

What's in it

  • Core: dataset readers auto-detect an OME-Zarr / DICOM store from its markers on read; the IMPACTReg feature loss gains a PCA reduction (torch, behaviourally identical to itk-impact's pca_fit/pca_transform).
  • Apps: the impact_reg registration app reuses model outputs and minimises orchestrator I/O; app.json inputs may declare default: ones|zeros so konfai-apps synthesises a missing optional input from Volume_0's header (no pixel load). CLI wrappers for IMPACT-Seg/Synth and MR/TotalSegmentator are smoke-tested; the register/eval CLI syntax is fixed.
  • Examples: a self-contained IMPACT-Reg registration demo (synthetic pair with a known warp, NCC ≈ 0.84 → ≈ 0.99, seam-free) and Colab notebooks for the packaged model apps.

Verification

Core + apps + konfai-mcp suites are green on the full stack; the store-format detection and the PCA metric are covered by unit tests.

@vboussot
vboussot force-pushed the feat/impactreg-omezarr-impact branch from f4f3d4b to 50cc3d6 Compare July 13, 2026 13:19
@vboussot
vboussot force-pushed the feat/impactreg-omezarr-impact branch from 50cc3d6 to 7a2b23d Compare July 14, 2026 13:19
@vboussot
vboussot force-pushed the feat/impactreg-omezarr-impact branch from 7a2b23d to 0119147 Compare July 14, 2026 13:26
@vboussot
vboussot force-pushed the feat/impactreg-omezarr-impact branch from 0119147 to 9a621a8 Compare July 14, 2026 13:34
Base automatically changed from konfai-mcp to main July 14, 2026 13:58
vboussot added 3 commits July 14, 2026 16:00
… PCA loss

Dataset readers auto-detect an OME-Zarr / DICOM store from its markers on read, and the IMPACTReg
feature loss gains a PCA reduction (torch, behaviourally identical to itk-impact's pca_fit/pca_transform).
Covered by unit tests.
…, and app CLI smoke tests

The impact_reg registration app reuses model outputs and minimises orchestrator I/O; app.json inputs
may declare default: ones|zeros so konfai-apps synthesises a missing optional input from Volume_0's
header (no pixel load). CLI wrappers for IMPACT-Seg/Synth and MR/TotalSegmentator are smoke-tested, and
the register/eval CLI syntax is fixed.
@vboussot
vboussot force-pushed the feat/impactreg-omezarr-impact branch from 9a621a8 to 6783c1b Compare July 14, 2026 14:00
@vboussot
vboussot merged commit 07a4a56 into main Jul 14, 2026
33 checks passed
@vboussot
vboussot deleted the feat/impactreg-omezarr-impact branch July 14, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant