fix: unblock Slicer inference (restore current_free_vram + file_system tensor sharing) - #35
Merged
Merged
Conversation
The params-primitive cleanup dropped current_free_vram along with the genuinely unused resolve_vram_plan_for_devices, but SlicerKonfAI imports current_free_vram to feed resolve_vram_plan for the advanced-dialog patch/batch preview (ImportError at runtime). Restore the helper; resolve_vram_plan_for_devices stays removed (no caller).
mp.spawn pickles the configured object (a loaded model); with the default file_descriptor strategy each CPU tensor takes one fd, exhausting the process open-file limit ('Too many open files') under Slicer's embedded Python. Switch to the file_system sharing strategy before spawn.
vboussot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #33's params cleanup removed
current_free_vramalongside the genuinely-unusedresolve_vram_plan_for_devices— but SlicerKonfAI importscurrent_free_vramto feedresolve_vram_planfor the advanced-dialog patch/batch preview, soon_advanced_clickedraisedImportErrorat runtime.Restores the helper (unchanged signature
current_free_vram(devices, remote_server=None) -> float | None).resolve_vram_plan_for_devicesstays removed — nothing calls it. My earlier dead-code grep only covered the KonfAI repo, missing the external SlicerKonfAI dependency.