This repository was archived by the owner on Jan 24, 2026. It is now read-only.
Add RejectAuth#6
Closed
staab wants to merge 1 commit into
Closed
Conversation
Owner
|
Maybe I am missing something, but I've commented there. To me it makes more sense to use what I suggested there together with |
Author
|
Yeah, this is a bad idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fiatjaf I don't think you'll like this, because it makes auth vulnerable for existing projects. But see nostr-protocol/nips#1079 for why I did it. I think this structure is better anyway, since it matches rejectx, but it does require the developer to validate the auth challenge.