Fix CPAN random tester regressions#852
Merged
Merged
Conversation
Fix caller stack reporting for generated accessors whose Java stack frame is no longer visible during tied hash FETCH callbacks. This restores Test2/Test::More context depth behavior for Class::Accessor::Fast. Add a Test::SharedFork distropref so CPAN can stage the module for downstream consumers while skipping its fork-only upstream tests on PerlOnJava. Generated with Codex https://openai.com/codex Co-Authored-By: Codex <codex@openai.com>
Only synthesize out-of-stack caller frames from the active RuntimeCode stack when an explicitly renamed CV is active and the selected active frame has a real subroutine name. This preserves the Class::Accessor::Fast Test2 context fix without fabricating top-level or ordinary Test::Builder frames. Generated with Codex https://openai.com/codex Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
callerstack reporting for generated accessors when a tied hash callback runs after the Java stack frame has disappeared.Sub::Util::set_subnameaccessors with tied hashFETCHandTest::Morecontext depth.Test::SharedForkso downstream pure-Perl tests can stage it while skipping its fork-only upstream tests.Verification
prove src/test/resources/unit/caller_line_number.ttimeout 1200 maketimeout 900 ./jcpan -t ...for:IO::ScalarExtUtils::CBuilderTest::DifferencesTest::MostDateTime::Calendar::TauStationDateTime::Format::RFC3501LWP::Protocol::httpsHTTP::CookiesClass::Accessor::FastModule::Build::PluggableFinal CPAN summary:
/tmp/cpan-regressions-final-summary.txt