docs(integration): fix broken LangChain adapter example in uagents-adapter README - #933
Open
feizhuzheng wants to merge 1 commit into
Open
docs(integration): fix broken LangChain adapter example in uagents-adapter README#933feizhuzheng wants to merge 1 commit into
feizhuzheng wants to merge 1 commit into
Conversation
feizhuzheng
requested review from
Alejandro-Morales,
Archento,
jrriehl,
lrahmani and
qati
as code owners
August 16, 2026 02:11
feizhuzheng
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LangChain adapter's quick-start example prints
result['agent_name'],result['agent_address']andresult['agent_port'], butLangchainRegisterTool._runbuilds its result dict with the keysname,portandaddress(seelangchain/tools.pylines 136-140 and 154) — it never emitsagent_*keys. So copy-pasting the documented example raisesKeyError: 'agent_name'.The identical print line in the CrewAI section (README line 117) is correct, because
CrewaiRegisterTool._rundoes buildagent_name/agent_address/agent_port(crewai/tools.pylines 635-642). The LangChain line looks like it was copied from the CrewAI example without adapting to the different return contract.Fix: update the LangChain example's print line to use the keys the LangChain tool actually returns (
name/address/port). Doc-only, one line; the CrewAI example is left untouched.(Alternatively the two adapters' return contracts could be aligned on the code side, but this doc fix is the minimal change.)
Verified by reading both adapters'
tools.pyand both README examples onmain.