Read and interpret GEOS-Chem prodloss fields#114
Merged
Conversation
joewallwork
added
enhancement
joewallwork
force-pushed
the
prodloss-fields-subdd
branch
from
977b50a to
300f8a4
Compare
joewallwork
force-pushed
the
prodloss-fields-subdd
branch
from
300f8a4 to
10a61ae
Compare
joewallwork
requested changes
Mar 27, 2025
joewallwork
left a comment
joewallwork
left a comment
Collaborator
There was a problem hiding this comment.
Looks good so far, thanks for this @AdelekeBankole.
Unfortunately, the arrays like prodbcpifrombcpo that you use in the top section haven't been imported and might not exist with the given names in the GISS Model anyway. (This is why the CI jobs fail for this PR.)
We'll need to figure out which arrays in the GISS Model correspond to these arrays and import and use them correctly. Failing that, we should replace these extractions with TODO notes.
Co-authored-by: Joe Wallwork <22053413+jwallwork23@users.noreply.github.com>
Co-authored-by: Joe Wallwork <22053413+jwallwork23@users.noreply.github.com>
Co-authored-by: Joe Wallwork <22053413+jwallwork23@users.noreply.github.com>
Co-authored-by: Joe Wallwork <22053413+jwallwork23@users.noreply.github.com>
Co-authored-by: Joe Wallwork <22053413+jwallwork23@users.noreply.github.com>
Co-authored-by: Joe Wallwork <22053413+jwallwork23@users.noreply.github.com>
Co-authored-by: Joe Wallwork <22053413+jwallwork23@users.noreply.github.com>
Co-authored-by: Joe Wallwork <22053413+jwallwork23@users.noreply.github.com>
Co-authored-by: Joe Wallwork <22053413+jwallwork23@users.noreply.github.com>
Co-authored-by: Joe Wallwork <22053413+jwallwork23@users.noreply.github.com>
Co-authored-by: Joe Wallwork <22053413+jwallwork23@users.noreply.github.com>
Co-authored-by: Joe Wallwork <22053413+jwallwork23@users.noreply.github.com>
Co-authored-by: Joe Wallwork <22053413+jwallwork23@users.noreply.github.com>
Co-authored-by: Joe Wallwork <22053413+jwallwork23@users.noreply.github.com>
Co-authored-by: Joe Wallwork <22053413+jwallwork23@users.noreply.github.com>
Co-authored-by: Joe Wallwork <22053413+jwallwork23@users.noreply.github.com>
* Convert Model E -> GEOS-Chem transfers to TODOs * Use valid derived type; loop over products and losses * Loops over products and losses for data transfer
joewallwork
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #111.
Merges into #102.