Move brand, design system and compare to /internal; make footers consistent - #29
Merged
Conversation
Ben asked for the brand guide, design system and the competitive analysis page to live under /internal — publicly reachable so they can be shared on request, but unlinked and out of the nav. Moves: docs/brand.html -> docs/internal/brand.html docs/design-system.html -> docs/internal/design-system.html docs/ferrosa-memory/compare.html -> docs/internal/compare.html The old addresses /brand.html and /design-system.html are NOT forwarded and now 404. Jean-Luis's call: nothing outside the site links to them. The Drive brand folder points at /brand.html and needs updating separately. Links removed: Brand and Design system from the homepage footer; the Compare tab from the five Memory nav bars; the two in-body Compare buttons on the Memory overview and How-it-works pages. Surrounding copy on those two sections was deliberately left alone — both sections are queued for their own pass, and rewriting now would be thrown away. The two Memory forwarding stubs were repointed at /internal rather than left dangling. Also, footers made consistent across all nine chrome pages: - The homepage lost the community footer in #23 and had a slimmer one-row footer instead. Restored to the standard footer every other page uses. - "Join our community" is an <h2>, and the ported layer's `.legacy-doc h2` (0,1,1) out-specified `.community-title` (0,1,0). On the two pages carrying .legacy-doc — forge/index.html and ferrosa-memory/getting-started.html — the heading rendered at 26px with a divider rule and ~80px of stacked space, making the footer 258px tall against 119px elsewhere. Restated after the ported block rather than editing it, per the standing rule. - The homepage body carries neither .product-page nor .legacy-doc, so the ported `.product-page footer { border-top }` never reached it. - Footer link row is now Memory / Database / Forge / Docs on every page; GitHub stays as the icon it already is in the community band. All nine footers now measure 119px with a 1px top border and three social icons at 1280px. design.config.json: two paths corrected, since it names design-system.html as its colour source and compare.html as one of the nine measured pages. That file is normally Ben's — flagging it here because the move forces it. Gates: check-site, check-contrast, measure-anatomy, find-empty-bands all pass; build-docs-nav produces no drift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Two things, in one PR because the second is forced by the first touching the homepage footer.
1. Move the internal pages to
/internalBen, Aug 18: "move brand and design system and the battle cards and everything else to, like, slash internal. It's available publicly, so you can actually share them if somebody asks, but it's not linked and it's not in people's face."
docs/brand.htmldocs/internal/brand.htmldocs/design-system.htmldocs/internal/design-system.htmldocs/ferrosa-memory/compare.htmldocs/internal/compare.htmlNothing is deleted. All three stay publicly reachable at their new addresses.
The old addresses now 404 — this is deliberate.⚠️ The Drive brand folder points at
/brand.htmland/design-system.htmlare not forwarded. Jean-Luis's call: nothing outside the site links to them./brand.htmland needs updating separately.Links removed (8): Brand + Design system from the homepage footer; the Compare tab from all five Memory nav bars; the two in-body Compare buttons on the Memory overview and How it works.
Deliberately not done: the copy around those two removed buttons was left as-is. Both sections are queued for their own pass; rewriting now would be thrown away. The "How it works" heading still reads "See it as tools, and against the alternatives" with only one button under it — known, tracked.
The two Memory forwarding stubs (
ferrosa-memory/brand.html,ferrosa-memory/design-system.html) were repointed at/internalrather than left dangling.No
/internalindex page — the ask was to move pages, not add one.No page matched "battle cards" — no such page exists in the repo.
2. Footers, now consistent across all nine pages
Two separate defects, found while removing the two homepage footer links:
a. The homepage lost the community footer in #23. #10 had deliberately pushed the homepage's community footer out to the seven product pages, making it the standard; #23 then replaced only the homepage's with a slimmer one-row footer. Restored to the standard.
b.
.legacy-doc h2was beating.community-title. "Join our community" is an<h2>. The ported layer carries.legacy-doc h2 { font-size; margin-top; border-top; padding-top }at (0,1,1), which out-specifies.community-titleat (0,1,0). On the two pages carrying.legacy-doc—forge/index.htmlandferrosa-memory/getting-started.html— the heading rendered at 26px with a divider rule and ~80px of stacked space above it, making the footer 258px tall against 119px everywhere else.Restated after the ported block rather than editing it, per the standing rule in this repo. Same treatment for the missing
border-topon the homepage, whose body carries neither.product-pagenor.legacy-doc.Footer link row is now Memory / Database / Forge / Docs on every page. GitHub stays as the icon it already is in the community band, rather than duplicating as a text link.
Measured at 1280px, all nine pages: 119px tall, 1px top border, 3 social icons, identical link row.
Note for Ben
design.config.jsonhas two path corrections — it namesdesign-system.htmlas its colour source andcompare.htmlas one of the nine measured pages, so the move forces them. Flagging since that file is normally yours.README.mdnow points at the old location of the design system in two places (the design-tokens note and thecheck-contrast.mjsrow). Left alone — your repo, your docs.Checks
check-site.pycheck-contrast.mjsmeasure-anatomy.mjsfind-empty-bands.mjsbuild-docs-nav.pygit diff --checkFooters were verified by measuring computed styles on all nine pages, since no gate covers footers.