fix(site): put every product page's content on its hero's left edge - #26
Merged
Conversation
Follows #24, which set the product-page geometry: a 1200px centred column inset by --gutter, so the Forge hero and its content share one left edge. The other product pages had not been brought onto it. Measured at 1440px: forge 193 / 193 <- #24, the target memory 193 / 145 database 193 / 145 tools, compare 193 / 177 getting-started 327 / 247 Three causes: - The ported sections were inset by the legacy 2rem inside the same 1200px column the hero insets by --gutter, so content sat left of its own hero. - Tools and Compare nest <section> inside <section>, so once the inset was corrected it applied twice and overshot to 273px. Only the outermost section carries the column now. - Getting Started was the last page still wrapping its content in the legacy 980px <main>, with the hero inside that wrapper rather than full-bleed. It now uses the same pattern #24 gave Forge — a neutralised main plus a .page-content column — and its hero is a sibling like everywhere else. All eight product pages now read 193/193. index.html stays at 80: it is the company page and keeps the wider 1560px measure deliberately, not by omission. No dead-space regression — every page still clean at the 150px bar except one 152px band on Compare, which is an ordinary section boundary carrying a divider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #24, which set the product-page geometry — a 1200px centred column inset by
--gutter, so the Forge hero and its content share one left edge. The other product pages had not been brought onto it.Measured at 1440px, left edge of the hero copy vs the first content block:
Three causes
The ported sections were inset by the legacy
2reminside the same 1200px column the hero insets by--gutter, so content sat 16–48px left of its own hero.Tools and Compare nest
<section>inside<section>. Once the inset was corrected it applied at every level and overshot to 273px. Only the outermost section carries the column now.Getting Started was the last page still wrapping its content in the legacy 980px
<main>, with the hero inside that wrapper rather than full-bleed. It now uses the same pattern #24 gave Forge — a neutralisedmainplus a.page-contentcolumn — and its hero is a sibling, like every other page.Result
All eight product pages read 193 / 193.
index.htmlstays at 80. It is the company page and keeps the wider 1560px measure deliberately — flagging that explicitly so it reads as a decision rather than a page that got missed.Verification
Note on approach
My earlier local work had pulled everything to a flush-left 1560px container at 80px instead. #24 landed first and established 1200-centred as the house geometry, so this conforms to that rather than relitigating it — the Forge page is the reference and is untouched here.