Skip to content

fix(site): put every product page's content on its hero's left edge - #26

Merged
bkearns merged 1 commit into
mainfrom
design/align-pass
Aug 19, 2026
Merged

fix(site): put every product page's content on its hero's left edge#26
bkearns merged 1 commit into
mainfrom
design/align-pass

Conversation

@bkearns

@bkearns bkearns commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Follows #24, which set the product-page geometry — a 1200px centred column inset by --gutter, so the Forge hero and its content share one left edge. The other product pages had not been brought onto it.

Measured at 1440px, left edge of the hero copy vs the first content block:

forge            193 / 193   <- #24, the target
memory           193 / 145
database         193 / 145
tools, compare   193 / 177
getting-started  327 / 247

Three causes

The ported sections were inset by the legacy 2rem inside the same 1200px column the hero insets by --gutter, so content sat 16–48px left of its own hero.

Tools and Compare nest <section> inside <section>. Once the inset was corrected it applied at every level and overshot to 273px. Only the outermost section carries the column now.

Getting Started was the last page still wrapping its content in the legacy 980px <main>, with the hero inside that wrapper rather than full-bleed. It now uses the same pattern #24 gave Forge — a neutralised main plus a .page-content column — and its hero is a sibling, like every other page.

Result

All eight product pages read 193 / 193.

index.html stays at 80. It is the company page and keeps the wider 1560px measure deliberately — flagging that explicitly so it reads as a decision rather than a page that got missed.

Verification

  • Left edges measured from the DOM on all nine pages, not eyeballed
  • No dead-space regression: every page still clean at the 150px bar, except one 152px band on Compare which is an ordinary section boundary carrying a divider rule
  • All six CI checks pass, contrast 127/127 AA
  • Reviewed rendered at 1440×1100 against a drawn 193px guide

Note on approach

My earlier local work had pulled everything to a flush-left 1560px container at 80px instead. #24 landed first and established 1200-centred as the house geometry, so this conforms to that rather than relitigating it — the Forge page is the reference and is untouched here.

Follows #24, which set the product-page geometry: a 1200px centred column inset
by --gutter, so the Forge hero and its content share one left edge. The other
product pages had not been brought onto it. Measured at 1440px:

    forge            193 / 193   <- #24, the target
    memory           193 / 145
    database         193 / 145
    tools, compare   193 / 177
    getting-started  327 / 247

Three causes:

- The ported sections were inset by the legacy 2rem inside the same 1200px
  column the hero insets by --gutter, so content sat left of its own hero.
- Tools and Compare nest <section> inside <section>, so once the inset was
  corrected it applied twice and overshot to 273px. Only the outermost section
  carries the column now.
- Getting Started was the last page still wrapping its content in the legacy
  980px <main>, with the hero inside that wrapper rather than full-bleed. It
  now uses the same pattern #24 gave Forge — a neutralised main plus a
  .page-content column — and its hero is a sibling like everywhere else.

All eight product pages now read 193/193. index.html stays at 80: it is the
company page and keeps the wider 1560px measure deliberately, not by omission.

No dead-space regression — every page still clean at the 150px bar except one
152px band on Compare, which is an ordinary section boundary carrying a divider.
@bkearns
bkearns merged commit e063852 into main Aug 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant