Represent list as a stream of data + sugar coat methods for Req/reply - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how we represent data for the data plane list methods. Unlike data plane write methods which take a stream of data, list methods return unary object and the router converts those objects into a stream of data. This was done this way since the first consumers of the list endpoint where req/reply APIs that return unary list of objects.
However, complex providers like Iceberg or Dbs have the ability to return data directly as an stream but had to be accommodated into this API.
This PR makes the default return type of the list method a stream and adds sugar coat functions for the methods that return single unary elements.