Skip to content

Use HTTPS for public submodules - #98

Merged
derekste merged 1 commit into
mainfrom
dev/https-submodules
Jul 14, 2026
Merged

Use HTTPS for public submodules#98
derekste merged 1 commit into
mainfrom
dev/https-submodules

Conversation

@derekste

Copy link
Copy Markdown
Member

Summary

Replace the four nested GitHub SSH submodule URLs with public HTTPS URLs.

This lets public downstream repositories use git clone --recurse-submodules without a GitHub account, SSH key, or credential helper. The submodule gitlinks are unchanged.

Validation

  • all four URLs resolve to the same public GitHub repositories
  • no git@github.com URL remains in .gitmodules
  • redis-pvxs-ioc will pin this commit and repeat a recursive clone with Git configuration, credential helpers, prompting, and SSH disabled

Copilot AI review requested due to automatic review settings July 14, 2026 17:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s Git submodule configuration to use public HTTPS URLs instead of GitHub SSH URLs, enabling unauthenticated recursive clones in downstream/public environments.

Changes:

  • Replaced git@github.com:... SSH submodule URLs with https://github.com/... URLs for all configured submodules.
  • Verified no git@github.com URLs remain in .gitmodules.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@wsulli wsulli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you tested this?

  • If not please do a fresh pull and make sure this works.

@derekste
derekste merged commit 9193b21 into main Jul 14, 2026
3 checks passed
@derekste
derekste deleted the dev/https-submodules branch July 14, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants