Add checkers and checksuites#28
Merged
Merged
Conversation
…rations, peak routed, structure line enforcement, and unit system checkers. Added mesh and stability checksuites. Made all relative imports absolute for pyinstaller.
thwllms
requested changes
Apr 28, 2026
thwllms
left a comment
thwllms
left a comment
Contributor
There was a problem hiding this comment.
@BenRufenacht great additions. Just a few q's / comments.
| from typing import List | ||
|
|
||
| ITER_FLAG = 1 | ||
| LAST_FLAG = 10 |
Contributor
There was a problem hiding this comment.
Would be nice to have a couple comments here explaining these defaults.
Contributor
Author
There was a problem hiding this comment.
Added to checker description.
| from pathlib import Path | ||
| from typing import List | ||
|
|
||
| MAX_VEL_FLAG = 15 |
Contributor
There was a problem hiding this comment.
Comment explaining this default?
Contributor
Author
There was a problem hiding this comment.
Added to checker description.
Contributor
|
One more thing -- the build is failing due to formatting checks. Run PS: also, you can bump the |
thwllms
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added erroneous cells, erroneous faces, max velocity, multi face n, iterations, peak routed, structure line enforcement, and unit system checkers. Added mesh and stability checksuites. Made all relative imports absolute for pyinstaller.