Stop --extend-zooms-if-still-dropping when zooming doesn't help - #386
Draft
ThibaudDauce wants to merge 1 commit into
Draft
Stop --extend-zooms-if-still-dropping when zooming doesn't help#386ThibaudDauce wants to merge 1 commit into
ThibaudDauce wants to merge 1 commit into
Conversation
ThibaudDauce
force-pushed
the
fix/extend-zooms-colocated-features
branch
from
April 6, 2026 10:26
2ac32ac to
894c2a1
Compare
When many features share identical coordinates, zooming in cannot resolve tile overflow because co-located features always end up in the same sub-tile regardless of resolution. Track whether all features in each overflowing tile share the same quadkey index. When every overflowing tile across all threads contains only co-located features, stop extending zoom levels since further subdivision is futile. Also skip generating child tiles for overflowing tiles where all features are co-located, avoiding redundant processing at deeper zooms.
ThibaudDauce
force-pushed
the
fix/extend-zooms-colocated-features
branch
from
April 6, 2026 11:31
894c2a1 to
bcf94c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When features are co-located (identical coordinates), zooming in cannot resolve tile overflow because the same features always end up in the same tile regardless of resolution. Previously this caused tippecanoe to loop from the calculated maxzoom all the way to zoom 24, wasting time generating tiles that never improve.After the first zoom extension, compare the worst tile's feature count and size with the previous zoom level. If neither metric improved, stop extending because further zooming is futile.Not working in a lot of cases, I think we can early return only if the distance between all points is 0. Will try this next.
Maybe fixes #338, #378