Clarify ST_DWithin macro documentation - #288
Open
davidwebster48 wants to merge 1 commit into
Open
Conversation
Document geometry vs geography units for st_dwithin/3, spell out the geography-only SQL overload for st_dwithin/4 (no casts), and tie st_dwithin_in_meters/4 to casts plus use_spheroid. co-authored by ai@fresha.com Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
@docstrings forst_dwithin/3,st_dwithin/4, andst_dwithin_in_meters/4so they match how PostGIS overloads work: units depend on geometry vs geography for the three-argument form, the four-argument SQL form is the geography overload (no casts inst_dwithin/4), andst_dwithin_in_meters/4is explicitly the cast-then-ST_DWithin/4path.Thanks to @aseigo for the review feedback that prompted these clarifications.