feat: Add scalable captial integration - #146
Conversation
6caab69 to
295bf80
Compare
| account if you have one. | ||
|
|
||
| > [!NOTE] | ||
| > Historical position value-on-a-date charts (as available for Trade Republic) are not yet |
There was a problem hiding this comment.
This is not a CLI limitation. sc broker chart --isin <ISIN> --timeframe max --json returns a price time series. See the comment on get_market_value_history. So we could think about implementing this in a future PR
There was a problem hiding this comment.
Implemented: get_market_value_history()/_fetch_value_history() now use sc broker chart --isin <ISIN> --timeframe max --json combined with the settled buy/sell/transfer history to build a real per-position value-over-time series (see build_daily_market_value_history in base.py).
Verified against a live account: broker chart returns data_points with mid_price/timestamp_utc (no result wrapper, matching the parsing), and after a fresh sync each position now shows its own distinct, correctly-varying valuation history tracking its actual buys/sells: no more flat single-point fallback. Docs updated accordingly.
295bf80 to
8943807
Compare
felixschndr
left a comment
felixschndr
left a comment
There was a problem hiding this comment.
Please see the 3 inline comments and fix the merge conflicts, then we can merge this into main.
Thanks for your contribution!
8943807 to
37003bd
Compare
|
Perfect, please fix the merge conflicts and then you are very welcome to bump the version to 0.4.0 |
…eature/scalable-capital # Conflicts: # source/backend/bank_handlers/base.py # source/backend/bank_handlers/trade_republic.py # tests/backend/bank_handlers/test_trade_republic.py
2 participants
scCLI.scbinary is auto-provisioned (downloaded, checksum-verified, and extracted) on first use if not already present.scsubcommands is ever invoked, and CLI output is parsed defensively (rate-limit retries, auth-error mapping, cursor-based pagination).