Add propellant line and line state value objects - #498
Merged
Conversation
felipebogaertsm
force-pushed
the
492-propellant-line-value-objects
branch
from
August 6, 2026 19:18
22557ff to
7afc992
Compare
A feed system that identifies its propellants by the attribute names fuel_tank and oxidizer_tank leaves no room for a third propellant, a single propellant, or an oxidizer-only hybrid feed. Add a PropellantLine holding the line name, its role and its Tank, plus a LineState holding the fluid mass and internal energy the integrator carries for that line. The role is a ComponentRole, whose ADDITIVE member covers a triliquid diluent or a coolant line. Nothing consumes these yet.
felipebogaertsm
force-pushed
the
492-propellant-line-value-objects
branch
from
August 17, 2026 00:44
7afc992 to
d233d06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #492.
The feed system identifies its propellants by the attribute names
fuel_tankandoxidizer_tank, which leaves no room for a third propellant, a single propellant, or an oxidizer-only hybrid feed.Adds
PropellantLine(name, role, tank) andLineState(fluid mass, internal energy), plusPropellantLine.initial_statefor the state the integrator starts from. The role reusesComponentRole, whoseADDITIVEmember covers a triliquid diluent or a coolant line. Pure addition; nothing consumes these yet.