[DEV-15635] Update download regex and add test case - #4713
Merged
Conversation
james-at-kc
reviewed
Aug 3, 2026
…pending-api into fix/dev-15635-adjust-download-sql-regex
…hub.com/fedspendingtransparency/usaspending-api into fix/dev-15635-adjust-download-sql-regex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix some of the download columns swapping their values due to similar names between the generated CSVs and the database columns.
Technical Details:
Django changed how the queryset queries are represented which broke the regex that is used to determine which columns are a direct select vs annotations. This PR updates that regex, removes some checks that were previously added, and then adds a test case to hopefully catch any future potential changes.
A decent amount of the changes came from running ruff format on the file.
Requirements for PR Merge:
Explain N/A in above checklist: