Skip to content

Parallelize root log - #91

Merged
tdawson merged 6 commits into
fedora-eln:masterfrom
tdawson:parallel-root-log
Aug 15, 2025
Merged

Parallelize root log#91
tdawson merged 6 commits into
fedora-eln:masterfrom
tdawson:parallel-root-log

Conversation

@tdawson

@tdawson tdawson commented Aug 13, 2025

Copy link
Copy Markdown
Member

Parallelize the dependency gathering when we download and processing a root log.
This was AI Assisted.

@tdawson

tdawson commented Aug 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

I have tested this enough to know that it does the parallelization, and that the command line option works.
I have not done a full test run to see the time difference between a parallelization of 1 vs the default of 10.
I don't recommend merging this until a full test run has been done.

yselkowitz
yselkowitz requested changes Aug 14, 2025
View reviewed changes

@yselkowitz yselkowitz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits 4 and 7 should be squashed into 1. That shouldn't invalidate testing since we're only testing the final result of the PR, which will be identical. Besides that, once change below.

Comment thread content_resolver/config_manager.py Outdated
@tdawson
tdawson force-pushed the parallel-root-log branch from 892c23e to 4a978a8 Compare August 15, 2025 13:51
@tdawson

tdawson commented Aug 15, 2025

Copy link
Copy Markdown
Member Author

I have squashed the relevant changes. (7 into 4) (8 into 6).

@tdawson

tdawson commented Aug 15, 2025

Copy link
Copy Markdown
Member Author

Github really has a hard time when "Change requests" are requested. There is no way to indicate that it's done.

@yselkowitz

yselkowitz commented Aug 15, 2025

Copy link
Copy Markdown
Member

Github really has a hard time when "Change requests" are requested. There is no way to indicate that it's done.

You can re-request review by clicking the circular arrows next to the reviewer.

yselkowitz
yselkowitz approved these changes Aug 15, 2025
View reviewed changes

@yselkowitz yselkowitz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once your tests have completed and you're satisfied with the results, please go ahead and merge.

@yselkowitz yselkowitz linked an issue Aug 15, 2025 that may be closed by this pull request
Content Resolver: parallelize root log #88
Closed
@yselkowitz yselkowitz mentioned this pull request Aug 15, 2025
Closed
@tdawson

tdawson commented Aug 15, 2025

Copy link
Copy Markdown
Member Author

It has passed all my tests. Merging it.

@tdawson
tdawson merged commit 702f06f into fedora-eln:master Aug 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yselkowitz yselkowitz yselkowitz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Content Resolver: parallelize root log

2 participants

@tdawson @yselkowitz