Skip to content

Fix up image workloads - #1478

Merged
tdawson merged 1 commit into
fedora-eln:mainfrom
tdawson:image-workloads2
Aug 13, 2025
Merged

Fix up image workloads#1478
tdawson merged 1 commit into
fedora-eln:mainfrom
tdawson:image-workloads2

Conversation

@tdawson

@tdawson tdawson commented Aug 13, 2025

Copy link
Copy Markdown
Member

There were several warnings from the original workloads. This fixes those.

Signed-off-by: Troy Dawson <tdawson@redhat.com>
@tdawson
tdawson merged commit a023d5e into fedora-eln:main Aug 13, 2025
1 check passed

@yselkowitz yselkowitz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give me a chance to review changes first.

- dnf-utils
- dracut-config-generic
- e2fsprogs
- efibootmgr

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

efibootmgr should be included but only for UEFI arches (x86_64 and aarch64).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is included on x86_64 and aarch64. But when I moved it down there, I forgot to remove it from the overall group.

- dnf-utils
- dracut-config-generic
- e2fsprogs
- efibootmgr

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto here.

@tdawson

tdawson commented Aug 13, 2025

Copy link
Copy Markdown
Member Author

Please give me a chance to review changes first.

Please trust me to do simple changes without you.

@tdawson

tdawson commented Aug 13, 2025

Copy link
Copy Markdown
Member Author

Please give me a chance to review changes first.

Please trust me to do simple changes without you.

Sorry, that came out with the wrong tone.
I'm trying to save you time by doing things pro-actively. But if you then have to come back and double check everything I do, then I haven't really saved you any time.
If this wasn't something I was comfortable with, I wouldn't have merged it.

@yselkowitz

Copy link
Copy Markdown
Member

The HA image still needs a fix though. fence-agents is one of those tricky packages which is a placeholder in ELN but is also a real package in Fedora and when listed in a workload (e.g. Extras, or here) it gets pulled in. HA is one area where things aren't so clean atm, see fedora-eln/eln#229. Maybe the HA image configs should be CS only?

@tdawson

tdawson commented Aug 14, 2025

Copy link
Copy Markdown
Member Author

I'm good with the HA image being CS only. I think that is the cleanest way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants