Clicking Follow on a locked account showed "Requested", but clicking again showed "Following" instead of cancelling the request.#28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
toggleFollowonly checkedfollowState(boolean) to decide follow vs unfollow. For locked accounts the API returns{ following: false, requested: true }— sofollowStatewasfalse, and the second click calledfollow()again instead ofunfollow()to cancel.Fixed
useFollows.ts—toggleFollownow treatsrequestedas "engaged". If eitherfollowingorrequestedis true, toggling callsunfollow()(cancel request). Optimistically clearsrequestedin the relationship cache for instant UI feedback, with rollback on error.Added
test/composables/useFollows.test.ts— 11 unit tests covering follow, unfollow, cancel pending request, optimistic state, API response handling, and error rollback.