Skip to content

docs: clarify +1 offset semantics for store_offset - #851

Open
funcpp wants to merge 1 commit into
fede1024:masterfrom
funcpp:docs/store-offset-semantics
Open

docs: clarify +1 offset semantics for store_offset#851
funcpp wants to merge 1 commit into
fede1024:masterfrom
funcpp:docs/store-offset-semantics

Conversation

@funcpp

@funcpp funcpp commented Jul 25, 2026

Copy link
Copy Markdown

commit and commit_message already document the +1 offset convention, but the store_offset* methods don't. They also don't agree with each other: store_offset stores offset + 1, while store_offsets stores offsets as is. That asymmetry is easy to miss without reading librdkafka's docs.

The wording is taken from librdkafka's own docs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant