Expand implementation of ToBytes for references to non-Sized types - #811
Open
Cerber-Ursi wants to merge 1 commit into
Open
Expand implementation of ToBytes for references to non-Sized types#811Cerber-Ursi wants to merge 1 commit into
Cerber-Ursi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now,
ToBytesis implemented for references, but only when the referenced type isSized. In particular, it's not implemented for&str, despite being implemented forstr; therefore every place expecting&T where T: ToBytes, when passed&&str, can lead to somewhat cryptic errors.This merge request relaxes requirements on
impl ToBytes for &Tand includes a simple unit test to ensure that this change actually removes the compilation error.