feat: replace GitHub search redirect with client-side Fuse.js search - #21
Open
mahir-b0 wants to merge 1 commit into
Open
feat: replace GitHub search redirect with client-side Fuse.js search#21mahir-b0 wants to merge 1 commit into
mahir-b0 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what this changes
replaces existing search engine which redirects users to Github code search with a proper client-side search that displays first 20 results inline on the page.
Why
previous implementation opened github.com/search in a new tab, which requires the user to be logged into GitHub, broke on mobile, and felt disconnected from the site experience.
testing
tested locally by running npm test and testing across multiple editions. there are some issues with non-English searches