refactor(ui): standardize section, floating-control, and icon patterns#57
Merged
Conversation
- Add shared Section, SectionDivider, and FloatingControl components - Refactor About, Experience, Skills, and Contact to use Section - Unify ThemeToggle and LanguageSwitcher border/hover/focus behavior - Normalize icon SVG attributes and remove unused Skype/Twitter icons - Make global focus-visible radius inherit element border-radius
Deploying portifolio with
|
| Latest commit: |
acb8047
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d4719a4b.portifolio-1p0.pages.dev |
| Branch Preview URL: | https://feature-ui-consistency-clean.portifolio-1p0.pages.dev |
- Make LanguageSwitcher panel h-11 to match ThemeToggle - Use h-9 buttons inside LanguageSwitcher for consistent vertical rhythm - Change skill badges from rounded (4px) to rounded-full - Align hover border color to accent for all bordered controls
- Add HeaderControls component that renders both in a single floating bar - Shrink ThemeToggle and LanguageSwitcher to h-9 (36px) - Remove individual FloatingControl wrappers from each component - Position combined controls at top-4 right-4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up UI components and theme setup for consistent spacing, borders, focus states, and icon handling.
Changes
Shared primitives
Section,SectionDivider, andFloatingControlcomponents.About,Experience,Skills, andContactto useSection.ContactusesSection as="div"to stay semantically inside<footer>.Floating controls (theme + language)
FloatingControlwrapper.hover:border-accent/50on the language switcher panel.:focus-visiblestyle.Focus ring
:focus-visibleborder-radiusfrom4pxtoinheritso the focus outline matches each element (circular onrounded-fullbuttons).Icons
SkypeandTwittericon types/components.xmlns,fill="currentColor",aria-hidden, andfocusable="false".[&>svg]:fill-currentworkaround fromContactlinks.Validation
npm run fmt:check✓npm run lint✓npm run build✓