Skip to content

[WIP] operating system incompatibility#750

Draft
janpio wants to merge 5 commits into
masterfrom
janpio-is_incompatible
Draft

[WIP] operating system incompatibility#750
janpio wants to merge 5 commits into
masterfrom
janpio-is_incompatible

Conversation

@janpio

@janpio janpio commented Nov 23, 2018

Copy link
Copy Markdown
Member

This PR relates to and depends on fastlane/fastlane#13703

TODO:

  • Update documentation in fastlane codebase to reflect the changes here "Action 'scan' is not compatible with operating system 'Windows'. For information how to handle this check out: TODO"
  • Update the documentation in this branch to reflect the TODO changes made to this line https://github.com/fastlane/fastlane/pull/13703/files#diff-dddea7a7468572e88e5b764b4506d25f15bb446e711e69c7413bc9cb85cccaccR308
  • Add FASTLANE_IGNORE_OS_INCOMPAT functionality to fastlane
  • Add def self.is_incompatible?(operating_system) functionality to fastlane
  • Add def self.is_incompatible?(operating_system) generation to fastlane new_action and fastlane new_plugin

@janpio janpio changed the title [WIP] Initial OS incompatibility documentation draft [WIP] operating system incompatibility Nov 23, 2018

@KrauseFx KrauseFx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the idea of having a single doc that describes all of this, nice 👍

Comment thread docs/best-practices/linux-windows.md Outdated
@google-cla

This comment has been minimized.

@rogerluan rogerluan marked this pull request as draft March 7, 2021 01:59
@google-cla google-cla Bot added cla: no and removed cla: yes labels Mar 7, 2021
@rogerluan

Copy link
Copy Markdown
Member

@googlebot I consent.

@google-cla google-cla Bot added cla: yes and removed cla: no labels Mar 7, 2021
@rogerluan

Copy link
Copy Markdown
Member

@janpio I like the idea of this doc very much!

I took the liberty of pushing a general formatting commit to your branch, and merged latest changes to it as well. Hope you don't mind 😇

Looks like this PR is very close from completion, what did you have in mind for the TODO comment in the code here? https://github.com/fastlane/fastlane/pull/13703/files#diff-dddea7a7468572e88e5b764b4506d25f15bb446e711e69c7413bc9cb85cccaccR308

@janpio

janpio commented Mar 9, 2021

Copy link
Copy Markdown
Member Author

The general idea was to have documentation how to work around this, and possibly also give people an idea how to contribute improvements and fixes that could help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants