Conversation
Puppo
marked this pull request as ready for review
October 4, 2026 16:00
ilteoood
approved these changes
Oct 4, 2026
ilteoood
left a comment
Member
There was a problem hiding this comment.
Approved via Hermes (richiesta utente).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a manually dispatched release workflow with
patch,minor, andmajorchoices, enabling approval-gated npm trusted publishing through the shared Fastify workflow.The release job grants
id-token: writeandcontents: writeand pinsfastify/workflows/.github/workflows/reusable-release.ymltob1a11bce713bc857e52b2231fec3c89071ad3135. The shared workflow uses thereleaseenvironment, commits/pushes the version bump, publishes with npm provenance, and creates the GitHub Release. This JavaScript package needs no release build step.Part of the JS-6 rollout batch, following the pilot in fastify/fastify-accepts#231.
Validation
Local validation with Node.js 24.21.0 and npm 11.19.0:
npm install --ignore-scripts --no-audit --no-fundpassed.npm run lintpassed.npm testpassed.npm pack: verifiedindex.js,types/index.d.ts, and unchanged package version10.1.5.Admin setup before the first release
These settings are not changed by this PR and remain unverified:
releaseenvironment with required reviewer teamfastify/releaseand deployment access exclusively for branchmain; check for extra branch/tag policies.GITHUB_TOKEN.@fastify/static: labelmanual-gha-release, organizationfastify, repositoryfastify-static, workflow filenamerelease.yml, environmentrelease, Allow publish enabled.No version bump, npm publication, release dispatch, or administrative settings/access changes were performed while preparing this draft.
Additional validation notes: