fix: preserve original error as cause in onError handler#480
Open
xianjianlf2 wants to merge 1 commit into
Open
fix: preserve original error as cause in onError handler#480xianjianlf2 wants to merge 1 commit into
xianjianlf2 wants to merge 1 commit into
Conversation
The onError handler received a wrapped FastifyError that stripped all information about the underlying error. This was especially visible with AggregateError (e.g. ECONNREFUSED to both ::1 and 127.0.0.1), whose message is always empty. Pass the original error as `cause` to every error forwarded to onError so it stays accessible. Closes fastify#451
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #451
The
onErrorhandler received a freshly-constructedFastifyErrorwrapper (ServiceUnavailableError,GatewayTimeoutError,InternalServerError, …) that discarded the original upstream error. This is worst with Node'sAggregateError(e.g.ECONNREFUSEDto both::1and127.0.0.1), whose.messageis empty — sonew InternalServerError(err.message)produced an empty message and no way to inspect the real cause.This passes
{ cause: err }to each of the 6 error constructors in the error branch (@fastify/errorv4 supports thecauseoption), so the original error stays accessible viaerror.causewhilemessage/statusCodeare preserved.error.cause === originalError.node --test→ 161 passed, lint clean.