test: improve coverage toward 100%#476
Open
antonisetkowicz wants to merge 1 commit into
Open
Conversation
Add tests for previously uncovered code paths: - base option as single-element array normalization (request.js:41-42) - HTTP agent close/destroy lifecycle (request.js:117-122) - Unsupported body type error in HTTP/1 mode (request.js:295-296) - Connection header stripping in HTTP/1 mode (request.js:131-136) Moves overall coverage from 97.76% to 98%. Ref fastify#367
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds tests for previously uncovered code paths, moving overall statement coverage from 97.76% to 98%.
New test cases
baseoption as single-element arrayrequest.js:41-42— array normalizationrequest.js:117-122— agent cleanup on closerequest.js:295-296— error pathrequest.js:131-136— RFC 7230 complianceRemaining gaps to 100%
index.js:206—UND_ERR_CONNECT_TIMEOUTerror handling (requires network timeout simulation)request.js:181—BalancedPoolorigin deletion (requires BalancedPool setup)request.js:199-200— undici connection header stripping loop (connection headers are removed by undici before reaching this code)All 164 existing tests + 4 new tests pass. Type tests pass.
Ref #367