Feature/fix tests - #39
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add __init__.py files for relative imports across test packages - Add conftest.py to boot minimal Application (needed by ConnectionFactory) - Fix all `fastapi_startkit.orm.*` imports → `fastapi_startkit.masoniteorm.*` - Fix config format: flat dict → nested `connections` key - Fix fixtures/model.py: import Field from masoniteorm.models.fields - Use RefreshDatabase trait in sqlite TestCase with overridden migrate_database - Fix sqlite test imports to use relative paths - Fix builder.py: `primary_key` → `__primary_key__` in find() - Add or_where() to QueryBuilder using QueryExpression keyword="or" - Fix test_model_attributes: correct config key access and unsupported driver name Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Remove duplicate skipped test_can_find_list (find() is now implemented) - Update expected SQL to include LIMIT 1 (find calls first()) - Call DB.clear() before wipe() in setUp/tearDown so mocked connections do not corrupt get_all_tables() in subsequent tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Rewrite test_collection.py to use fixture User/DB/migrate and sqlite TestCase - Remove Factory dependency (not implemented) — use direct model instances - Remove Schema old-API setup — migrate_database() from TestCase handles it - Fix group_by assertIsInstance to not depend on specific Collection class Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Move tests to top level
feat: fix the tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.