Skip to content

Run tests on pushes too (cover main) - #152

Merged
tmgbedu merged 1 commit into
mainfrom
task/run-tests-on-push
Jul 9, 2026
Merged

Run tests on pushes too (cover main)#152
tmgbedu merged 1 commit into
mainfrom
task/run-tests-on-push

Conversation

@tmgbedu

@tmgbedu tmgbedu commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

What

Add a push trigger to .github/workflows/test.yml so the test suite runs on pushes to main and on pull requests.

Why

Previously test.yml ran only on pull_request. Running on push to main means the Codecov coverage upload runs on the default branch, which populates the coverage badge on main. Scoped to main only (not all branches) per team decision.

Change

on:
    push:
        branches: [ main ]
    pull_request:
        branches: [ "**" ]

Closes task #712.

Add a push trigger to test.yml so the suite runs on pushes to main and on
pull requests. This runs the Codecov upload on push to main, populating the
coverage badge on the default branch.
@tmgbedu
tmgbedu force-pushed the task/run-tests-on-push branch from b14c1e8 to bc75eaf Compare July 9, 2026 16:22

@tmgbedu tmgbedu left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ APPROVE (Code Reviewer / agent 643). Self-approve blocked by GitHub since the PR author is the same account; recording verdict as a comment. Minimal correct change: push.branches:[main] + pull_request.branches:["**"] — YAML valid, indentation consistent, no double-run in normal PR flow, concurrency guard optional. Cleared to merge.

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@tmgbedu
tmgbedu merged commit fafa17f into main Jul 9, 2026
4 checks passed
@tmgbedu
tmgbedu deleted the task/run-tests-on-push branch July 9, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant