chore: drop dependency to proc-macro-error2#12
Merged
Conversation
Signed-off-by: tison <wander4096@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR removes the proc-macro-error2 dependency from the stacksafe-macro proc-macro crate by switching to syn::Result/syn::Error for error reporting, and updates the workspace dependency set accordingly.
Changes:
- Replace
proc-macro-error2abort-based error handling withsyn::Errorpropagation andinto_compile_error()emission. - Introduce an internal
stacksafe_implreturningsyn::Result<TokenStream>and adapt parsing tosyn::parse2/Parser::parse2. - Update workspace dependency declarations and lockfile to drop
proc-macro-error2and bump related crate versions.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| stacksafe-macro/src/lib.rs | Reworks macro entrypoint and error handling to remove proc-macro-error2 usage. |
| stacksafe-macro/Cargo.toml | Drops proc-macro-error2, adds direct proc-macro2 dependency. |
| Cargo.toml | Updates workspace dependency list to remove proc-macro-error2 and pin proc-macro2 and other crates. |
| Cargo.lock | Reflects dependency graph changes: removes proc-macro-error2 packages and updates resolved versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: tison <wander4096@gmail.com>
c9447fa to
e7d3ea4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.