Add ID conversion check in CharacterFactory - #551
Open
glmdgrielson wants to merge 5 commits into
Open
Conversation
This should fix issue farirpgs#536.
Whoops, should have read the whole file.
glmdgrielson
had a problem deploying
to
Preview
November 5, 2024 17:56 — with 
GitHub Actions
Failure
GitHub Actions
Failure
I know this is bad practice, but the whole point of this test is that it's working on bad data.
glmdgrielson
had a problem deploying
to
Preview
November 5, 2024 18:50 — with
GitHub Actions
Failure
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix issue #536.
✅ Changes
🌄 Context
As per issue #536, Fari currently makes no checks on the imported JSON and accepts it without question.
🔒Checklist
💅 Examples