Repository navigation
Cover expired player callbacks deterministically - #73
Merged
Merged
Conversation
|
Review changes with Changed Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage of the expired-item guard varies between otherwise identical CI runs. Move the existing nil guard into the playback-status handler and add a regression proving that an expired callback leaves replacement playback and its deadline unchanged. Preserve the weak captures and MainActor hop.
Validation: three complete AuraKit coverage collections, including a clean rebuild, produce identical per-file counts and retain all 938 methods plus 30 argument cases. The ordinary package command also passes. Full and two-shard iOS collection pass all 79 methods and retain all 592 snapshot renders with identical coverage measurements. Both iOS and macOS builds pass.