Skip to content

Repository navigation

test(fal): document and verify the uploader socket default #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dennybritz merged 2 commits into from
Oct 5, 2026
Merged

test(fal): document and verify the uploader socket default #1198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17aa14c
refactor(fal): define the local uploader socket directory
dennybritz Oct 5, 2026
50ec4fc
refactor(fal): keep only the consumed socket default
dennybritz Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions projects/fal/src/fal/toolkit/file/_local_uploader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
if TYPE_CHECKING:
import httpx

# Keep in sync with infra/modules/nomad_jobs/jobs.tf and isolate-cloud's
# projects/isolate_controller/src/isolate_controller/scheduler/nomad/forger.py.
DEFAULT_SOCKET_PATH = "/run/fal-upload/upload.sock"
_TIMEOUT = 300
_CONNECT_TIMEOUT = 5
Expand Down
16 changes: 16 additions & 0 deletions projects/fal/tests/unit/toolkit/file/test_local_uploader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,22 @@
STARTED = {**ACCEPTED, "upload_id": "session-id", "state": "receiving"}


@pytest.mark.parametrize("socket_path", [None, "/tmp/custom-uploader.sock"])
def test_client_socket_path(monkeypatch, socket_path):
monkeypatch.delenv("CDN_UPLOADER_SOCKET_PATH", raising=False)
if socket_path is not None:
monkeypatch.setenv("CDN_UPLOADER_SOCKET_PATH", socket_path)
transport = Mock(wraps=httpx.HTTPTransport)
monkeypatch.setattr(httpx, "HTTPTransport", transport)

with _local_uploader._new_client():
pass

assert transport.call_args.kwargs["uds"] == (
socket_path if socket_path is not None else "/run/fal-upload/upload.sock"
)


@pytest.fixture
def transport(monkeypatch):
requests = []
Expand Down
Loading