Add X-2 Delegates; Chr and DamageBuffer structs - #239
Open
jmcx532 wants to merge 7 commits into
Open
Conversation
EvelynTSMG
suggested changes
Jul 29, 2026
EvelynTSMG
reviewed
Jul 29, 2026
fkelava
requested changes
Jul 30, 2026
fkelava
left a comment
fkelava
left a comment
Collaborator
There was a problem hiding this comment.
STEP bits (src/core/ffx2/call_*.g.cs, reject.ffx2.rsp) look good except this one thing.
Collaborator
|
Mechanical parts:
LGTM. What remains is checking the added signatures and names. |
fkelava
approved these changes
Aug 6, 2026
fkelava
left a comment
fkelava
left a comment
Collaborator
There was a problem hiding this comment.
As previously said, mechanical side LGTM. Still requires Evelyn's approval on the structs and delegates themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.