Feat/analytics overhaul(notification fix) - #16
Merged
Conversation
…he required classes to prevent them from obfuscation
…it's used and passed down not shaked nor not used
…dd the 'androidStopForegroundOnPause' attribute and set it to false (i have no idea what that does but it was made to keep everything smooth not essential for anything)
…ested switching from 'querysongs()' to 'queryaudiofrom()')
…le and probable same unique id (more on that in the comments)
… stream to half the overhead and rebuilds since it is not needed to update every 250ms
…albes i made in the drawable folder, tht was the problem that waas making the background notificatio disappear, explanation: the minification wasa discarding the drawables thinking it is useless assets to lighten the app, and when the notification tried to build using the drawables it didn't find them, resulting in the notification not being built at all, by having this file it makes sure to keep those specific assets for the building of the notification which has worked (this only happened in the release run/build)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary:
- ensure that the notification is working
- ditch the useless proguard file
- various minor optimizations for the searching for a specific song and setting the queue to reduce overhead