Categorize optimizer step and construction frames as OPTIMIZER#20
Closed
Chenguang-Zhu wants to merge 1 commit into
Closed
Categorize optimizer step and construction frames as OPTIMIZER#20Chenguang-Zhu wants to merge 1 commit into
Chenguang-Zhu wants to merge 1 commit into
Conversation
Summary: Expand the OPTIMIZER name set and add a filename-based OPTIMIZER rule to capture vanilla `torch.optim`, TorchRec keyed optimizer, Distributed Shampoo, and additional in-house optimizer implementations. Public name additions in `_OPTIMIZER_VANILLA_NAMES`: - step, _per_group_step_impl - create_optimizer, _create_optimizer, create_keyed_optimizer - _instantiate_shampoo_preconditioner_list, _create_kronecker_factors_state, _create_kronecker_factors_state_for_block, _create_base_kronecker_factors Public filename-substring rule (`_OPTIMIZER_FILENAME_SUBSTRINGS`): - torch/optim/optimizer.py - torchrec/optim/keyed.py In-house optimizer rules are injected via the `mosaic.libmosaic.utils.internal_optimizer_rules` extension hook so the OSS-shipping `data_utils.py` carries no internal-only path strings or symbol names. Differential Revision: D103992613
|
@Chenguang-Zhu has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103992613. |
|
This pull request has been merged in 1b2bfb3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Expand the OPTIMIZER name set and add a filename-based OPTIMIZER rule
to capture vanilla
torch.optim, TorchRec keyed optimizer, DistributedShampoo, and additional in-house optimizer implementations.
Public name additions in
_OPTIMIZER_VANILLA_NAMES:_create_kronecker_factors_state,
_create_kronecker_factors_state_for_block,
_create_base_kronecker_factors
Public filename-substring rule (
_OPTIMIZER_FILENAME_SUBSTRINGS):In-house optimizer rules are injected via the
mosaic.libmosaic.utils.internal_optimizer_rulesextension hook so theOSS-shipping
data_utils.pycarries no internal-only path strings orsymbol names.
Differential Revision: D103992613