Refactor from_frame_stack into a rule-table architecture (no behavior change)#16
Closed
Chenguang-Zhu wants to merge 1 commit into
Closed
Refactor from_frame_stack into a rule-table architecture (no behavior change)#16Chenguang-Zhu wants to merge 1 commit into
Chenguang-Zhu wants to merge 1 commit into
Conversation
… change) Summary: Pure refactor of `AllocationType.from_frame_stack`. Replace the flat for-loop if-cascade with a list of `(predicate, category)` rules at module scope and add small private helper predicates: - `_any_filename_contains` - `_any_filename_matches_regex` - `_any_frame_name_in` - `_any_frame_name_contains` - `_any_frame_name_startswith` - `_no_frame_name_in` The 12 existing rules are migrated 1-to-1 in their original priority order. The function body becomes "iterate the table; first matching rule wins; else UNKNOWN". This sets up subsequent diffs to add new rules without bloating the function body. Differential Revision: D103992611
|
@Chenguang-Zhu has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103992611. |
|
This pull request has been merged in b5095dd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Pure refactor of
AllocationType.from_frame_stack. Replace the flatfor-loop if-cascade with a list of
(predicate, category)rules atmodule scope and add small private helper predicates:
_any_filename_contains_any_filename_matches_regex_any_frame_name_in_any_frame_name_contains_any_frame_name_startswith_no_frame_name_inThe 12 existing rules are migrated 1-to-1 in their original priority
order. The function body becomes "iterate the table; first matching
rule wins; else UNKNOWN". This sets up subsequent diffs to add new
rules without bloating the function body.
Differential Revision: D103992611