Skip to content

Fix PYRE_MISSING_ANNOTATIONS issues in fbcode/HolisticTraceAnalysis/hta/common/trace_filter.py #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
meta-codesync wants to merge 1 commit into from
Closed

Fix PYRE_MISSING_ANNOTATIONS issues in fbcode/HolisticTraceAnalysis/hta/common/trace_filter.py #349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hta/common/trace_filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ def __call__(


class NameStringColumnFilter(Filter):
def __init__(self, name_pattern: str):
def __init__(self, name_pattern: str) -> None:
self.name_pattern = name_pattern

def __call__(
Expand Down Expand Up @@ -319,7 +319,7 @@ def __call__(

def _filter_gpu_kernels_with_cuda_sync(
df: pd.DataFrame, symbol_table: TraceSymbolTable
):
) -> pd.Series:
"""Helper function that finds rows in the dataframe that are either
GPU kernels or CUDA synchronization events."""

Expand Down
Loading