Fix 2 broken tests caused by D98706662 (#329)#329
Closed
firoz1905 wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@firoz1905 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99399645. |
meta-codesync
Bot
changed the title
firoz1905
pushed a commit
to firoz1905/HolisticTraceAnalysis
that referenced
this pull request
Apr 3, 2026
Summary: Pull Request resolved: facebookresearch#329 Differential Revision: D99399645
firoz1905
force-pushed
the
export-D99399645
branch
from
7e5a1d2 to
f5519bd
Compare
Summary: Pull Request resolved: facebookresearch#329 Differential Revision: D99399645
firoz1905
force-pushed
the
export-D99399645
branch
from
f5519bd to
3c4dee1
Compare
Contributor
Author
|
Closing this PR. This was an auto-generated fix (Devmate) to unbreak internal tests after D98706662 landed before its dependency D98705186. The changes here (adding MAX_EVENT_DURATION_US and max_event_duration_us to ParserConfig) are already included in #325 (D98705186). Landing internally only. |
firoz1905
pushed a commit
to firoz1905/HolisticTraceAnalysis
that referenced
this pull request
Apr 3, 2026
Summary: Pull Request resolved: facebookresearch#329 Differential Revision: D99399645
firoz1905
pushed a commit
to firoz1905/HolisticTraceAnalysis
that referenced
this pull request
Apr 3, 2026
Summary: Pull Request resolved: facebookresearch#329 Differential Revision: D99399645
firoz1905
pushed a commit
to firoz1905/HolisticTraceAnalysis
that referenced
this pull request
Apr 7, 2026
Summary: Pull Request resolved: facebookresearch#329 Differential Revision: D99399645
firoz1905
pushed a commit
to firoz1905/HolisticTraceAnalysis
that referenced
this pull request
Apr 7, 2026
Summary: Pull Request resolved: facebookresearch#329 Differential Revision: D99399645
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Pull Request resolved: #329
Differential Revision: D99399645