Skip to content

[Nexthop] Use real timestamps from retrieved port stats for port line rate calculation #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vvasavada-nexthop wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

[Nexthop] Use real timestamps from retrieved port stats for port line rate calculation #1505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion fboss/agent/hw/test/HwSwitchEnsemble.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,8 +892,15 @@ bool HwSwitchEnsemble::waitForRateOnPort(
// interpacket gap. Account for that in linerate.
auto packetPaddingBytes = (curPortPackets - prevPortPackets) * 20;
auto curPortBytes = *curPortStats.outBytes_() + packetPaddingBytes;
// Port stats are sampled asynchronously by the stats thread, so the
// real interval between two samples can differ from the requested
// sleep duration. Use the actual timestamp delta when available.
const int elapsedSec = static_cast<int>(
*curPortStats.timestamp_() - *prevPortStats.timestamp_());
const int rateDurationSec =
elapsedSec > 0 ? elapsedSec : secondsToWaitPerIteration;
auto rate = static_cast<uint64_t>((curPortBytes - prevPortBytes) * 8) /
secondsToWaitPerIteration;
rateDurationSec;
if (desiredBps == 0 && rate == desiredBps) {
XLOG(DBG0) << "Expect no traffic: Current rate " << rate << " bps!";
return true;
Expand Down