Add support for threads_user_id to AdSet, AdCreative, and related cla…#501
Open
arnabnandy7 wants to merge 1 commit into
Open
Add support for threads_user_id to AdSet, AdCreative, and related cla…#501arnabnandy7 wants to merge 1 commit into
arnabnandy7 wants to merge 1 commit into
Conversation
…sses Add threads_user_id as a first-class field, query/request parameter, and getter/setter across the SDK, aligning with how instagram_user_id is currently supported. - AdSet: added mThreadsUserId field, getter/setter, and added to FIELDS/requests in APIRequestGetAdCreatives, APIRequestGetCopies, and APIRequestGet. - AdCreative: added mThreadsUserId field, getter/setter, APIRequestGet, and copied in copyFrom. - AdCreativeObjectStorySpec: added mThreadsUserId field, getter/setter, and copied in copyFrom. - Ad: added threads_user_id to FIELDS and requests in APIRequestGetAdCreatives. - AdAccount: added threads_user_id to FIELDS and requests in APIRequestGetAdCreatives, APIRequestGetAdCreativesByLabels, APIRequestGetAdSets, APIRequestGetAdSetsByLabels, APIRequestGetAffectedAdSets, and APIRequestGetDeprecatedTargetingAdSets. Added threads_user_id to PARAMS and setThreadsUserId to APIRequestCreateAdCreative. - Campaign: added threads_user_id to FIELDS and requests in APIRequestGetAdSets. - AdLabel: added threads_user_id to FIELDS and requests in APIRequestGetAdCreatives and APIRequestGetAdSets. - AdStudyCell: added threads_user_id to FIELDS and requests in APIRequestGetAdSets. Resolves facebook#497
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the issue where
threads_user_idwas not supported as a direct field, query/request parameter, or getter/setter in the Java Business SDK. We have added full support forthreads_user_idacross the SDK in the same locations whereinstagram_user_idis supported, allowing developers to target and manage placements on the Threads platform directly instead of relying on setting it as a miscellaneous/custom field.Key Changes
SDK Models
AdSet:@SerializedName("threads_user_id")field and member variablemThreadsUserId.getFieldThreadsUserId()andsetFieldThreadsUserId(String value)."threads_user_id"toFIELDSarray inAPIRequestGetAdCreatives,APIRequestGetCopies, andAPIRequestGet.requestThreadsUserIdFieldmethods toAPIRequestGetAdCreatives,APIRequestGetCopies, andAPIRequestGet.AdCreative:@SerializedName("threads_user_id")field and member variablemThreadsUserId.getFieldThreadsUserId()andsetFieldThreadsUserId(String value)."threads_user_id"toFIELDSarray inAPIRequestGet.requestThreadsUserIdFieldmethods toAPIRequestGet.mThreadsUserIdin thecopyFromcopy-constructor method.AdCreativeObjectStorySpec:@SerializedName("threads_user_id")field and member variablemThreadsUserId.getFieldThreadsUserId()andsetFieldThreadsUserId(String value).mThreadsUserIdin thecopyFromcopy-constructor method.Ad:"threads_user_id"toFIELDSarray and addedrequestThreadsUserIdFieldmethods toAPIRequestGetAdCreatives.API & Endpoint Requests
AdAccount:"threads_user_id"toFIELDSarray and addedrequestThreadsUserIdFieldmethods in:APIRequestGetAdCreativesAPIRequestGetAdCreativesByLabelsAPIRequestGetAdSetsAPIRequestGetAdSetsByLabelsAPIRequestGetAffectedAdSetsAPIRequestGetDeprecatedTargetingAdSets"threads_user_id"toPARAMSarray and addedsetThreadsUserId(String threadsUserId)toAPIRequestCreateAdCreative.Campaign:"threads_user_id"toFIELDSarray and addedrequestThreadsUserIdFieldmethods toAPIRequestGetAdSets.AdLabel:"threads_user_id"toFIELDSarray and addedrequestThreadsUserIdFieldmethods toAPIRequestGetAdCreativesandAPIRequestGetAdSets.AdStudyCell:"threads_user_id"toFIELDSarray and addedrequestThreadsUserIdFieldmethods toAPIRequestGetAdSets.Verification Done
javacafter the additions.Resolves #497